Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change tooltip placement to top #5809

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

GeronimoJohn
Copy link
Contributor

@GeronimoJohn GeronimoJohn commented Dec 15, 2024

Fixes #4892

πŸ‘©πŸ»β€πŸ’» What does this PR do?

The current placement of the tooltip obscures or hides data entry fields. To fix this issue we are to move up the placement of the tooltip from bottom to the top.

Screenshot 2024-12-16 at 6 00 15β€―PM

πŸ’Œ Any notes for the reviewer?

πŸ§ͺ Testing

  • Visit any page that renders a data table
  • Hover over the column title
  • Tooltip should be rendering at the top of the text

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@GeronimoJohn GeronimoJohn added bug Something is borken good first issue Good for newcomers front-end Front-end related Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release Team Korimako LachΓ©, Aimee, Noel John, and Zachariah labels Dec 15, 2024
@GeronimoJohn GeronimoJohn added this to the v2.5.0 milestone Dec 15, 2024
Copy link

Bundle size difference

Comparing this PR to main

Old size New size Diff
4.99 MB 4.99 MB -9 B (-0.00%)

@lache-melvin lache-melvin self-assigned this Dec 16, 2024
Copy link
Contributor

@lache-melvin lache-melvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay thank you! Side note - if you could add a screenshot to your PRs when you create UI changes, that would be lovely for getting context going into a review 😁

@GeronimoJohn GeronimoJohn merged commit fcfed80 into develop Dec 16, 2024
8 checks passed
@GeronimoJohn GeronimoJohn deleted the 4892-update-tooltip-placement branch December 16, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken front-end Front-end related good first issue Good for newcomers Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release Team Korimako LachΓ©, Aimee, Noel John, and Zachariah
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover overs can obscure or hide data entry fields
2 participants