DRAFT 4776 de techify new report modal #4804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And default expiry now
github-actions
bot
added
enhancement
fergie-nz
commented
Sep 17, 2024
| @@ -29,11 +29,15 @@ export const ReportArgumentsModal: FC<ReportArgumentsModalProps> = ({ | |||
| monthsItemsExpire, | |||
| } = store?.preferences ?? {}; | |||
|
|
|||
| // default expiry date as now formatted to datepicker | |||
| const expiryDate = new Date().toISOString().slice(0, 10); | |||
There was a problem hiding this comment.
I wondered if made more sense to have this default coming through with report json schema, but it was much easier to call date here rather than try and add functions to json
fergie-nz
commented
Sep 17, 2024
Comment on lines
+12
to
+13
| /// Search term must begin with (case insensitive) | ||
| starts_with: Option<String>, |
There was a problem hiding this comment.
have added starts_with to string filter.
Is this okay? I was wondering why we didn't have all implementations of StringFilter included already?
|
This PR will be streamlined to just make modal text changes - remaining changes have not been triaged |
fergie-nz
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4776
👩🏻💻 What does this PR do?
Works with changes made in omSupply reports PR https://github.com/msupply-foundation/open-msupply-reports/pull/93
💌 Any notes for the reviewer?
🧪 Testing
You can test this report by upserting the new reports from the #4776 reports branch, and then generating a new report.
You will see the modal has changed and search for code or name on standard reports now runs by 'starts with' rather than 'contains'
📃 Documentation
See new issue: Update documentation for simplified report modal msupply_docs#88