266 - Fixup tool tip errors #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size differenceComparing this PR to
|
EthanMcQ-TMF
commented
Mar 1, 2024
Comment on lines
+56
to
+57
| <div> | ||
| <BaseButton |
There was a problem hiding this comment.
Mui tooltip expects it's child to accept ref which react function components do not. A simple fix is to just... wrap it in a non-function component
jmbrunskill
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #266
👩🏻💻 What does this PR do?
Fix console errors that occur when displaying certain tooltips.
🧪 How has/should this change been tested?
Loading up the events view and checking the console, you should no longer see tooltip errors.
These errors were also causing the tooltips to fail to display, so you should now be able to hover over date entries and actually see the tooltip
💌 Any notes for the reviewer?
📃 Documentation
No user facing changes