262 show template errors #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lache-melvin
commented
Nov 27, 2023
| const isInvalid = | ||
| !draft.title || | ||
| // nothing selected | ||
| !isValidTemplate(draft.subjectTemplate) || | ||
| !isValidTemplate(draft.bodyTemplate) || |
There was a problem hiding this comment.
Would we ever send a notification with a subject but no body? Or a blank subject and just a body? i.e. do both subject and body need to exist, as well as being valid, or just that they need to be valid if they do exist?
There was a problem hiding this comment.
I think we should always have a body.
Telegram only renders the body, subject is just for email in current design.
jmbrunskill
approved these changes
Nov 28, 2023
| const isInvalid = | ||
| !draft.title || | ||
| // nothing selected | ||
| !isValidTemplate(draft.subjectTemplate) || | ||
| !isValidTemplate(draft.bodyTemplate) || |
There was a problem hiding this comment.
I think we should always have a body.
Telegram only renders the body, subject is just for email in current design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262 (this PR is part 2)
👩🏻💻 What does this PR do?
Uses the tera-web package to validate whether the templates are parse-able, and displays an error state if not. Also prevents being able to save a broken template.
Makes subject and body template fields always full width too, to prevent their width jumping around as the error shows and hides:
i.e. this closes #214
🧪 How has/should this change been tested?
💌 Any notes for the reviewer?