Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

185 configuable temperature limits for cold chain #188

Merged
merged 9 commits into from
Oct 25, 2023

Conversation

jmbrunskill
Copy link
Collaborator

Closes #185

👩🏻‍💻 What does this PR do?

image

Acceptance criteria

  • defaults are visible and easy to configure
  • custom limits can be specified (for all sensors in the config)
  • Update i icon messages to explain the default limits

🧪 How has/should this change been tested?

  • Update the limits and check that they are saved correctly.
  • Check that limits are disabled when not enabled
  • Check defaults are correctly set

💌 Any notes for the reviewer?

No backend changes were needed for this, as it was already handled correctly in the backend.

@jmbrunskill jmbrunskill linked an issue Oct 10, 2023 that may be closed by this pull request
5 tasks
@github-actions
Copy link

Bundle size difference

Comparing this PR to main

Old size New size Diff
2.1 MB 2.1 MB 4.42 KB (0.21%)

@jmbrunskill jmbrunskill changed the base branch from main to 171-cold-chain-should-send-high-and-low-temperature-alerts October 13, 2023 01:42
@jmbrunskill jmbrunskill changed the base branch from 171-cold-chain-should-send-high-and-low-temperature-alerts to 186-cold-chain-alerts-should-default-to-enabled October 13, 2023 01:43
Base automatically changed from 186-cold-chain-alerts-should-default-to-enabled to main October 16, 2023 20:29
@mark-prins mark-prins self-assigned this Oct 17, 2023
@mark-prins
Copy link
Contributor

It might be helpful to have the two limits affect each other to prevent misconfiguring like so:

image

Copy link
Contributor

@mark-prins mark-prins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Lovely - that's working nicely. As usual, I've popped in a UI suggestion..

:nit The '1 Minutes' and '1 Hours' could be more elegant. Even just changing to 'Minute(s)' 🤔

image

@jmbrunskill
Copy link
Collaborator Author

👍 Lovely - that's working nicely. As usual, I've popped in a UI suggestion..

:nit The '1 Minutes' and '1 Hours' could be more elegant. Even just changing to 'Minute(s)' 🤔

image

Kapture 2023-10-25 at 16 02 44

Probably overkill but why not :)

@jmbrunskill
Copy link
Collaborator Author

It might be helpful to have the two limits affect each other to prevent misconfiguring like so:

image

image

Added an error in this situation. No explanation text but again, I think as long as we call attention to it, we should be ok.

@jmbrunskill jmbrunskill merged commit 2b79913 into main Oct 25, 2023
@jmbrunskill jmbrunskill deleted the 185-configuable-temperature-limits-for-cold-chain branch October 25, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuable temperature limits for Cold Chain
2 participants