186 cold chain alerts should default to enabled #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size differenceComparing this PR to
|
|
Is this one targeting the right branch to merge into? There's a lot of files changed for what sounds like a simple task 🤔 |
jmbrunskill
changed the base branch from
main
to
171-cold-chain-should-send-high-and-low-temperature-alerts
Nope! Good catch should be right now. |
Base automatically changed from
171-cold-chain-should-send-high-and-low-temperature-alerts
to
main
October 13, 2023 02:46
jmbrunskill
deleted the
186-cold-chain-alerts-should-default-to-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #186
👩🏻💻 What does this PR do?
Default to all alerts turned on for Cold Chain
🧪 How has/should this change been tested?
💌 Any notes for the reviewer?
I've also removed the backwards compatibility code for recipientIds, as I think the only placing which was still using this old method has been updated now.