Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1586 Header tweaks #1592

Merged
merged 7 commits into from
Nov 5, 2023
Merged

#1586 Header tweaks #1592

merged 7 commits into from
Nov 5, 2023

Conversation

CarlosNZ
Copy link
Collaborator

@CarlosNZ CarlosNZ commented Nov 5, 2023

Partly addresses #1586, but doesn't deal with the org dropdown.

Basically, makes things flow better around each other for both mobile and desktop at a wider range of viewport sizes:

Desktop

  • UserMenu button shouldn't wrap, and will expand to fit the name (up to a limit)
  • Menu bar shouldn't force org name out of the header (used "position:absolute" for it)
  • "Brand Area" logo disappears earlier as the viewport shrinkg

Mobile

  • Header bar size reduced (from 80px to 60)
  • Org name fits better into space, and font-size reduced
  • Make some margins/padding smaller

CarlosNZ
CarlosNZ commented Nov 5, 2023
View reviewed changes
semantic/src/site/globals/site.overrides
@@ -325,12 +321,16 @@ a:hover {
padding-top: 8px;
padding-bottom: 8px;
}
@media only screen and (max-width: 860px) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 860 is just an arbitrary amount based on what seemed reasonable on my screen.

src/containers/User/UserArea.tsx Show resolved Hide resolved
@CarlosNZ CarlosNZ requested a review from guatemartin November 5, 2023 20:03
guatemartin
guatemartin approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@guatemartin guatemartin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It tidied up with a really long name as well in the Header.
image

@CarlosNZ CarlosNZ merged commit 34620b7 into feature/angola-ui-improvments Nov 5, 2023
@CarlosNZ CarlosNZ deleted the header-tweaks branch November 5, 2023 22:58
@CarlosNZ CarlosNZ mentioned this pull request Nov 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guatemartin guatemartin guatemartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarlosNZ @guatemartin