fix ensemble converter bug #410
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensemble data with obspy functions would create output that caused the database save method to abort. The problem was related to a subtle mishandling of an internal set container used to handle the conversion of ensemble Metadata. This commit fixes the problem but hasn't been verified with pytest. It shouldn't fail but could.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes a serious bug in handling ensemble data. When obspy functions were applied to ensembles the previous version obspy functions would create output that caused
the database save method to abort. The problem was related to
a subtle mishandling of an internal set container used to handle the
conversion of ensemble Metadata. This commit fixes the problem
but hasn't been verified with pytest. It shouldn't fail but could. My fix was tested on a subset of the 2012 usarray data and it solved the problem. Look at my fixes with a bit of skepticism to see if there is a cleaner solution. The way the decorators are interwoven made this hard to track so changes from what I suggest should be done cautiously.