[experimental-tmp] Add Nokia Lumia msm8x26 range of devices #222
+37
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of #157
This PR adds a proper device tree with all Nokia msm8x26 devices. Some of these have variants that come with msm8926 instead of msm8226 (and I think the 830 only comes with msm8926) but I don't think it's worth adding a msm8926-v1-mtp.dts that would be identical.
These devices boot lk2nd differently to other devices, as they use a UEFI bootloader which we break out of using a shim. They need the device tree bundling in with
LK2ND_BUNDLE_DTB=msm8226-v1-mtp.dtband the compatible setting withLK2ND_COMPATIBLE=<device compatible>. They also need a different MEMBASE,0x01D00000or0x07300000is what have worked for me.Last PR was talking about putting some build instructions in README and having a comment about these devices in the dts. Not super sure what to put in the dts, what I put previously apparently had weird format?