Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GNUInstallDirs to set installation directories #1108

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Use GNUInstallDirs to set installation directories #1108

merged 1 commit into from
Mar 7, 2024

Conversation

Zopolis4
Copy link

@Zopolis4 Zopolis4 commented Mar 7, 2024

Allow the user to override directories via typical options if necessary, otherwise use the GNU defaults.

Only change in behaviour is to install into ${prefix}/lib64 on systems where the following conditions are met.

  #  - we are on Linux system but NOT cross-compiling
  #  - we are NOT on debian
  #  - we are NOT building for conda
  #  - we are on a 64 bits system

Resolves #981

@Zopolis4
Copy link
Author

Zopolis4 commented Mar 7, 2024

It seems like the AppVeyor CI fail is unrelated to my changes.

@redboltz
Copy link
Contributor

redboltz commented Mar 7, 2024

It seems like the AppVeyor CI fail is unrelated to my changes.

Yes, I think so. But our human resource is very limited. In this case, I ask you to fix it even if it is not related to your fix.
I've checked the appveyor error.
The error is caused by non exisitng link http://zlib.net/zlib-1.3.tar.gz
It should be http://zlib.net/zlib-1.3.1.tar.gz

Here is appveyor setup file:
https://github.com/msgpack/msgpack-c/blob/2c0040cef6e0cd9f871979bb6e6b57fa74de0d46/appveyor.yml

Please try replacing all 1.3 to 1.3.1.

@redboltz
Copy link
Contributor

redboltz commented Mar 7, 2024

I just merged your appveyor update pull requests. Could you rebase this PR from the merged cpp_master ?

@codecov-commenter
Copy link

Codecov Report

Merging #1108 (d1af4a3) into c_master (5f287d1) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           c_master    #1108   +/-   ##
=========================================
  Coverage     55.45%   55.45%           
=========================================
  Files             8        8           
  Lines          1044     1044           
=========================================
  Hits            579      579           
  Misses          465      465           

@redboltz redboltz merged commit 68d085a into msgpack:c_master Mar 7, 2024
19 checks passed
@redboltz redboltz added the C label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants