cmake: add headers to interface library #1057
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmake 3.19 allows headers to be added to interface libraries in order to populate IDE projects
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## cpp_master #1057 +/- ##
===========================================
Coverage 85.60% 85.60%
===========================================
Files 79 79
Lines 5023 5023
===========================================
Hits 4300 4300
Misses 723 723 |
redboltz
reviewed
Mar 27, 2023
| @@ -6,6 +6,11 @@ PROJECT (msgpack-cxx LANGUAGES CXX) | |||
|
|
|||
| ADD_LIBRARY (msgpack-cxx INTERFACE) | |||
|
|
|||
| IF (CMAKE_VERSION VERSION_GREATER_EQUAL 3.19) | |||
| FILE(GLOB_RECURSE SOURCE_FILES include/*hpp) | |||
There was a problem hiding this comment.
Suggested change
| FILE(GLOB_RECURSE SOURCE_FILES include/*hpp) | |
| FILE(GLOB_RECURSE SOURCE_FILES include/*.hpp) |
I read https://cmake.org/cmake/help/v3.7/command/file.html globbing-expressions examples.
It seems that *.hpp can avoid unexpected match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake 3.19 allows headers to be added to interface libraries in order to populate IDE projects