Expose .Internal types #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nh2
force-pushed
the
v2.0.1-expose-internal
branch
3 times, most recently
from
2d0e4c7 to
aa7df78
Compare
mrkkrp
force-pushed
the
v2.0.1-expose-internal
branch
from
aa7df78 to
9fbf3f7
Compare
mrkkrp
approved these changes
Jun 19, 2024
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the library!
We're implementing low-level IO improvements for ZIP files of a specific shape, in particular to work around https://gitlab.haskell.org/ghc/ghc/-/issues/24220 on networked file systems.
For that to work, we need the
internalmodules exposed; this PR upstreams that. It will also help others who want to use the lower-level parts of this library.Thank you!