Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LabeledString): Joi.objectt({name: joi.string().label()}) #96

Closed
wants to merge 0 commits into from

Conversation

tomasPavlacky
Copy link

No description provided.

@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #96 (c72fdbb) into master (36a9ebe) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head c72fdbb differs from pull request most recent head 2df577e. Consider uploading reports for the commit 2df577e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   98.36%   98.34%   -0.03%     
==========================================
  Files           7        7              
  Lines         368      363       -5     
  Branches      115      111       -4     
==========================================
- Hits          362      357       -5     
  Misses          6        6              
Impacted Files Coverage Δ
src/parse.ts 96.70% <100.00%> (-0.09%) ⬇️
src/analyseSchemaFile.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a9ebe...2df577e. Read the comment docs.

@mrjono1
Copy link
Owner

mrjono1 commented May 2, 2021

@tomasPavlacky thankyou for the PR I'll check it out in conjunction with #85 as I think they may conflict

@mrjono1
Copy link
Owner

mrjono1 commented May 2, 2021

they did conflict :(
Is it possible to use Joi.description() or Joi.note() in your use case instead of Joi.label() ?
On a side note I am not sure if using Joi.label() is the correct choice here is some more thoughts on it #53 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants