Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handling for sparse arrays #373

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

toddtarsi
Copy link
Contributor

Resolves #324

@toddtarsi
Copy link
Contributor Author

@mrjono1 - Thank you for the very impressive codebase. Please let me know if I can do anything to help expedite the process of getting this fix out, thanks!

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4b689fe) 98.67% compared to head (768d10e) 98.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   98.67%   98.68%           
=======================================
  Files           9        9           
  Lines         529      532    +3     
  Branches      203      205    +2     
=======================================
+ Hits          522      525    +3     
  Misses          7        7           
Files Coverage Δ
src/parse.ts 97.43% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/parse.ts Show resolved Hide resolved
@toddtarsi
Copy link
Contributor Author

@mrjono1 - All requested changes are made!

@mrjono1 mrjono1 merged commit 840a017 into mrjono1:master Oct 13, 2023
4 checks passed
@mrjono1
Copy link
Owner

mrjono1 commented Oct 13, 2023

@toddtarsi
Copy link
Contributor Author

Woohoo! Thank you @mrjono1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversion not respecting Joi sparse array and including undefined in type
2 participants