Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes, more robust application✅ #141

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Minor changes, more robust application✅ #141

wants to merge 2 commits into from

Conversation

Sagar0-0
Copy link

  1. Added string resource files
  2. Using FragmentContainerView instead of Fragment
  3. Using app:tint instead of android:tint
  4. Added contentDescription to images
  5. Formatted all XML files.

All tests passed✅
Please accept it as a valid PR, Thanks.

@Sagar0-0 Sagar0-0 requested a review from mrcsxsiq as a code owner October 22, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcsxsiq mrcsxsiq Awaiting requested review from mrcsxsiq mrcsxsiq is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sagar0-0