SW-3951 backend refactor the printer profile class and use it to implement rotary profile #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 22, 2023 20:33
The profile class is a modified version of the printerProfile class from OctoPrint. It has been modified to be able to serve as a parent class that can be implemented for different purposes and for different profile schemas.
This class implements the profile parent class to be used for laser cutter profiles.
|
✅ Linked to Story SW-3951 · BACKEND - Refactor the printer profile class and use it to implement Rotary profile |
added 16 commits
October 23, 2023 11:57
irlaec
suggested changes
Oct 25, 2023
irlaec
approved these changes
Nov 21, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
khaledsherkawi
merged commit 97a7d42
into
feature/SW-3719-rotary-milestone-1-end-of-september
5 checks passed
khaledsherkawi
deleted the
feature/SW-3951-backend-refactor-the-printer-profile-class-and-use-it-to-implement-rotary-profile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SW-3951 Add profile class
The profile class is a modified version of the printerProfile class from OctoPrint. It has been modified to be able to serve as a parent class that can be implemented for different purposes and for different profile schemas.
SW-3951 Add laser cutter profile model
SW-3951 Add laser cutter profile service
This class implements the profile parent class to be used for laser cutter profiles.
SW-3951 Add laser cutter profiles to constants
SW-3951 Refactor services
SW-3951 Remove duplicated class
SW-3951 Refactor laser cutter profiles viewmodel
SW-3951 Implement the new laser cutter profile service