Commits on Nov 17, 2021

1. Report broken i2c status in front-end …

   Major:
   
   - Add a new Error message in the front end: i2c broken
   - Only show 1 error at a time - the one with highest priority
   - Fan handler does not time out as long as some data comes regularly
   -
   
   Refactor:
   
   - docstrings
   - var = foo[bar] => foo.get(bar, var) # when bar is not a mandatory key
   - Add comments in some obscure code places
   - foo == False => not foo
   - magic number => constant
   - mutate constant => copy constant as private var
   - Simplify Threads (un-nesting)
   - except: => except Exception: (does not catch SIGTERM)
   - Remove superflous try / except
   - logger.error(my_exception) => logger.exception(my_exception)
   - def foo(): pass => foo = do_nothing_func
     - saves lines
     - highlights that foo() is not important
   - complex if / elif key in foo: bar(foo[key]) => use lookup map
     - better readability
     - saves a bunch of lines (see _handle_fan_dynamic)
   - foo.get("bar", None) == "barbar" => foo.get("bar") == "barbar"
   - Repeated foo[bar] => var = foo[bar]
   - Avoid basic classes as var names (str)
   - Remove unused functions
   
   Minor :
   
   - Handles partial fan dynamic datasets as an update (refresh) for the dynamic dataset
   
   Known bug: If iobeam reports partial operational data (new default), the laser temperature gets "out of date" and stops the laser job

   

   amrsoll committed Nov 17, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for a6b748e
   • Browse repository at this point

   Copy the full SHA

   a6b748e View commit details

   Browse the repository at this point in the history