Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full API Implementation #75

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Full API Implementation #75

wants to merge 20 commits into from

Conversation

mrb0nj
Copy link
Owner

@mrb0nj mrb0nj commented Feb 25, 2020

Placeholder PR for full API implementation

build.cake Outdated
Configuration = configuration,
NoBuild = true,
OutputDirectory = "./artifacts",
ArgumentCustomization = args => args.Append($"-p:PackageVersion={gitVersion.NuGetVersionV2}")
Copy link
Contributor

@jchannon jchannon Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also have edit/delete the Version task as that won't be updating AssemblyInfo any more. Might have to set UpdateAssemblyInfo = false but I assume it still will calculate the correct version number. Not sure how it does that. I know MinVer will use git tags and/or do a count of commits since the last git tag to give you 1.0.56 for example. UPDATE Looks to work the same way https://gitversion.net/docs/examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants