-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C API for Ethereum BLS signatures #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and properly wait for process exit
CI:
Windows https://github.com/mratsim/constantine/actions/runs/4730674374/jobs/8394686963#step:21:43 (probably #230)
MacOS https://github.com/mratsim/constantine/actions/runs/4730674374/jobs/8394687314#step:19:25
|
I'll fix the issues introduced by LTO in another PR as it's getting quite long and distracting. So LTO is disabled for now. |
This was referenced Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ec2 @willemolding
This PR productionizes Constantine as a backend for Ethereum Consensus.
The PR can be tested with:
A C header is available in
include/constantine_ethereum_bls_signatures.h
The dynamic and static library will be placed in
lib/
aslibconstantine_ethereum_bls_signatures.so
(or .dll or .dylib)The example C file is in
example_c/ethereum_bls_signatures.c
Prerequisites
TODOs
Compiler-related:
API-related:
constantine/constantine/ethereum_bls_signatures.nim
Lines 604 to 609 in 98f7fd6
Out-of-scope of this PR
Feedback on API welcome.