fix MSM bench using 64-bit scalar after #444 (#460)

mratsim · Aug 19, 2024 · b850dc7 · b850dc7
1 parent 618d8b3
commit b850dc7
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 3 deletions.
diff --git a/benchmarks/bench_elliptic_parallel_template.nim b/benchmarks/bench_elliptic_parallel_template.nim
@@ -56,14 +56,14 @@ proc multiAddParallelBench*(EC: typedesc, numInputs: int, iters: int) =
 type BenchMsmContext*[EC] = object
   tp: Threadpool
   numInputs: int
-  coefs: seq[BigInt[64]] # seq[getBigInt(EC.getName(), kScalarField)]
+  coefs: seq[getBigInt(EC.getName(), kScalarField)]
   points: seq[affine(EC)]
 
 proc createBenchMsmContext*(EC: typedesc, inputSizes: openArray[int]): BenchMsmContext[EC] =
   result.tp = Threadpool.new()
   let maxNumInputs = inputSizes.max()
 
-  const bits = 64 # EC.getScalarField().bits()
+  const bits = EC.getScalarField().bits()
   type ECaff = affine(EC)
 
   result.numInputs = maxNumInputs
@@ -104,7 +104,7 @@ proc createBenchMsmContext*(EC: typedesc, inputSizes: openArray[int]): BenchMsmC
   stdout.write &"in {float64(inNanoSeconds(stop-start)) / 1e6:6.3f} ms\n"
 
 proc msmParallelBench*[EC](ctx: var BenchMsmContext[EC], numInputs: int, iters: int) =
-  const bits = 64 # EC.getScalarField().bits()
+  const bits = EC.getScalarField().bits()
   type ECaff = affine(EC)
 
   template coefs: untyped = ctx.coefs.toOpenArray(0, numInputs-1)

diff --git a/media/bench-bls12_381_msm-256_to_16384-R7_7840U.png b/media/bench-bls12_381_msm-256_to_16384-R7_7840U.png
diff --git a/media/bench-bls12_381_msm-2_to_128-R7_7840U.png b/media/bench-bls12_381_msm-2_to_128-R7_7840U.png
diff --git a/media/bench-bls12_381_msm-65536_to_262144-R7_7840U.png b/media/bench-bls12_381_msm-65536_to_262144-R7_7840U.png