Update suggestion constantine/math/config/precompute.nim

mratsim · Sep 23, 2023 · 990651f · 990651f
1 parent 089fe41
commit 990651f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/constantine/math/config/precompute.nim b/constantine/math/config/precompute.nim
@@ -399,7 +399,7 @@ func primeMinus1div2*(P: BigInt): BigInt =
   ## Warning ⚠️: Result is in the canonical domain (not Montgomery)
 
   result = P
-  discard result.sub(1)
+  # discard result.sub(1) # right-shifting automatically implies "-1" for odd numbers (which all prime >2 are).
   result.shiftRight(1)
 
 func primeMinus3div4_BE*[bits: static int](