Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifyadress #308

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Simplifyadress #308

wants to merge 5 commits into from

Commits on Apr 4, 2020

  1. Use INET_ADDRSTRLEN instead of hardcoding it 

    INET_ADDRSTRLEN is portable and allow to be robust against special crafted adress

signed-off: Bastien Roucariès <[email protected]>
    @bastien-roucaries
    bastien-roucaries committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    6d65f1d View commit details
    Browse the repository at this point in the history

  2. Let IPs resolve using getaddrinfo 

    getaddrinfo is the correct API for resolving IP and checking correctness

Use it, instead of manual parsing
    @khorben @bastien-roucaries
    khorben authored and bastien-roucaries committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    4c73258 View commit details
    Browse the repository at this point in the history

  3. Factorize IP resolution between http and https 

    Less code and less copy/paste thus less errors
    @bastien-roucaries
    bastien-roucaries committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    94bed23 View commit details
    Browse the repository at this point in the history

  4. Be more consistent when creating ~/.fwknoprc

    @khorben @bastien-roucaries
    khorben authored and bastien-roucaries committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    03e1c20 View commit details
    Browse the repository at this point in the history

  5. Improve IPV4 min length by using strlen

    @bastien-roucaries
    bastien-roucaries committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    de84936 View commit details
    Browse the repository at this point in the history