Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

Commit

Permalink
Restore versions in the build plugins
Browse files Browse the repository at this point in the history 
These versions numbers were removed in 236b20e and caused an error
during publication:

    $ meteor publish
    => Errors while publishing:

    While publishing the package:
    error: You must specify a version constraint for package blaze
    error: You must specify a version constraint for package underscore
    error: You must specify a version constraint for package htmljs
    error: You must specify a version constraint for package minifiers
    error: You must specify a version constraint for package spacebars-compiler

Note that the dependency version that will actually get includes will
be higher that the one we specified thanks to the Meteor constraints
solver.
  • Loading branch information
@mquandalle
mquandalle committed Oct 9, 2015
1 parent e01d1aa commit 0aa860f
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions packages/jade/package.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ Package.describe({
Package.registerBuildPlugin({
name: "compileJade",
use: [
"underscore",
"htmljs",
"minifiers",
"spacebars-compiler",
"underscore@1.0.0",
"htmljs@1.0.0",
"minifiers@1.0.0",
"spacebars-compiler@1.0.0",
"mquandalle:[email protected]"
],
sources: [
Expand All @@ -21,7 +21,7 @@ Package.registerBuildPlugin({
});

Package.onUse(function (api) {
api.use("blaze");
api.use("blaze@2.0.0");
});

Package.onTest(function (api) {
Expand Down

3 comments on commit 0aa860f

@darrynten
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the versions reflect those used by Meteor 1.2?

@mquandalle
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think so. Given the way Meteor handle constraints solving @1.0.0 basically mean at least 1.0.0, ie 1.x.x. For instance we don’t use any feature added in ulterior version of underscore so saying that we want at least 1.0 is fine. It’s likely that the actual user of package will have some extra constraints on underscore (such as using Meteor 1.2 as you say), so the constraint solver will choose a later version of it, which is perfectly fine assuming that are no breaking change in the 1.x.x range.

That would be an issue if I had implied that I want exactly underscore@=1.0.0, in which case the solver wouldn’t now how to reconcile the different constraints.

@darrynten
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes perfect sense.

Thanks

Please sign in to comment.