Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dislike count from backend_youtube_dl #305

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Cupcakus
Copy link

Most videos no longer have a dislike count on YT, this was cuasing errors and crashes.

Copy link

@yam-1111 yam-1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLS PUSH THIS!!

@michael-je
Copy link

michael-je commented Nov 25, 2021

If anyone needs a working version right now then you can check out this modification I made on one of my own projects.
I just copied some of the source code and created a pafy_fixed version by changing only what was necessary. It then becomes a drop-in replacement for pafy.

@mohamed-challal
Copy link

If you need a temporary fix
run pip install -e git+git://github.com/mohamed-challal/pafy.git@develop#egg=pafy
or simply add -e git+git://github.com/mohamed-challal/pafy.git@develop#egg=pafy to your requirements.txt

@YASSlNE
Copy link

YASSlNE commented Dec 2, 2021

please fix this asap

FarisHijazi
FarisHijazi approved these changes Dec 5, 2021
@FarisHijazi
Copy link

QUICK FIX

You could just install pafy from this pull request (until the request is accepted)

pip uninstall -y pafy
pip install git+https://github.com/Cupcakus/pafy

plewsh
plewsh approved these changes Dec 26, 2021
Copy link

@alec-jensen alec-jensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this problem is breaking my code, this needs to be added as soon as possible

Copy link

@mthfrr mthfrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link

@Balakishan77 Balakishan77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As dislike_count is not coming in the YouTube data, this commit will resolve the issue. Below are the current keys we are getting from YouTube feed.

['id', 'title', 'formats', 'thumbnails', 'description', 'upload_date', 'uploader', 'uploader_id', 'uploader_url', 'channel_id', 'channel_url', 'duration', 'view_count', 'average_rating', 'age_limit', 'webpage_url', 'categories', 'tags', 'is_live', 'subtitles', 'like_count', 'channel', 'track', 'artist', 'album', 'creator', 'alt_title', 'extractor', 'webpage_url_basename', 'extractor_key', 'playlist', 'playlist_index', 'thumbnail', 'display_id', 'requested_subtitles', 'requested_formats', 'format', 'format_id', 'width', 'height', 'resolution', 'fps', 'vcodec', 'vbr', 'stretched_ratio', 'acodec', 'abr', 'ext']

Copy link

@FurigaJulien FurigaJulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for a realease !

Copy link

@seanreynoldscs seanreynoldscs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

ghost
ghost approved these changes Mar 4, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XandarNull
XandarNull approved these changes Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.