UAReferenceContext - causes circular references #558

- removed IsSubtypeOf - it is not longer used. - UT 👍
mpostol · Apr 4, 2021 · c6ec12c · c6ec12c
1 parent 29b295f
commit c6ec12c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/SemanticData/Tests/USNodeSetValidationUnitTestProject/AddressSpaceContextUnitTest.cs b/SemanticData/Tests/USNodeSetValidationUnitTestProject/AddressSpaceContextUnitTest.cs
@@ -128,8 +128,7 @@ public void ImportUANodeSetTest()
       asp.UTGetReferences(NodeId.Parse(newNodeSet.Items[0].NodeId), x => references.Add(x));
       Assert.AreEqual<int>(1, references.Count);
       Assert.AreEqual<ReferenceKindEnum>(ReferenceKindEnum.HasProperty, references[0].ReferenceKind);
-      //UAReferenceContext - causes circular references #558
-      Assert.IsTrue(references[0].IsSubtypeOf(ReferenceTypeIds.HasProperty));
+      Assert.AreEqual<ReferenceKindEnum>(ReferenceKindEnum.HasProperty, references[0].ReferenceKind);
       references.Clear();
       asp.UTGetReferences(NodeId.Parse(newNodeSet.Items[1].NodeId), x => references.Add(x));
       Assert.AreEqual<int>(2, references.Count);

diff --git a/SemanticData/UANodeSetValidation/UAReferenceContext.cs b/SemanticData/UANodeSetValidation/UAReferenceContext.cs
@@ -46,14 +46,6 @@ internal UAReferenceContext(Reference reference, IAddressSpaceBuildContext addre
 
     #region semantics
 
-    //TODO UAReferenceContext - causes circular references #558
-    internal bool IsSubtypeOf(NodeId referenceType)
-    {
-      List<IUANodeContext> inheritanceChain = new List<IUANodeContext>();
-      m_AddressSpace.GetBaseTypes(TypeNode, inheritanceChain);
-      return inheritanceChain.Where<IUANodeContext>(x => x.NodeIdContext == referenceType).Any<IUANodeContext>();
-    }
-
     /// <summary>
     /// Gets the kind of the reference.
     /// </summary>