Skip to content

Commit

Permalink
Add generation blocking criterion to Sobol -> MBM criterion (facebook…
Browse files Browse the repository at this point in the history
…#3018)

Summary:
Pull Request resolved: facebook#3018

By adding this criterion at the sobol to mbm criterion, we push the data requirement check into the GenerationStrategy layer, which makes the most sense as having data is required for the modeling layer to succeed.

Reviewed By: saitcakmak

Differential Revision: D65434205

fbshipit-source-id: 347f04d03e55509eef149fd91cc3ded0624bbc85
  • Loading branch information
mgarrard authored and facebook-github-bot committed Dec 18, 2024
1 parent f316a7b commit ceb07f5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ax/modelbridge/generation_strategy.py
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ def gen_for_multiple_trials_with_multiple_models(
a trial being suggested and each inner list represents a generator
run for that trial.
"""
self.experiment = experiment
trial_grs = []
pending_observations = (
extract_pending_observations(experiment=experiment) or {}
Expand Down

0 comments on commit ceb07f5

Please sign in to comment.