Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the option to run the versioning logic within a queue job #95

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jivanrij
Copy link

@jivanrij jivanrij commented Dec 7, 2022

These changes make it possible to handle all versioning logic within a queue job.

I don't know if this will be a proper update because this maybe moves the package a bit away from simple and easy.

I needed it for an application that has a huge load of queue jobs (around 5000 per hour). Most of the time the server load was under 1 (at peak moments 2), but after adding versioning it start hitting 2 (10 on peak moments). I needed to remove the versioning because of this.

Now the versioning logic can be handled after those peak moments.

Feel free to give me some points to improve if you see fit and are interested in merging.

@nonoesp
Copy link
Collaborator

nonoesp commented Dec 7, 2022

Hi @jivanrij, this package is being minimally maintained to keep it working. But we won't add new functionality at the moment. Thanks a lot for the pull request either way!

@iateadonut
Copy link
Contributor

@nonoesp if i wrote tests for this, would you want to merge it?

@nonoesp
Copy link
Collaborator

nonoesp commented Mar 29, 2023

Hey! Can you elaborate a bit more on how this works?

@iateadonut
Copy link
Contributor

iateadonut commented Apr 1, 2023

I haven't looked into the source code, but I assume that it creates a job and puts the job into queue rather than updating the versioning table on update so that updating the versioning table is removed from the current request and does not have to be completed before termination.

It would require a queue running in the background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants