Save a COUNT query if all records should be kept

This query turned out to be the bottleneck on a project of mine. If you intend to keep all versions there is no need to count them.
mpociot · Jan 13, 2020 · ef5832a · ef5832a
1 parent b7c1bbe
commit ef5832a
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/src/Mpociot/Versionable/VersionableTrait.php b/src/Mpociot/Versionable/VersionableTrait.php
@@ -195,17 +195,20 @@ protected function versionablePostSave()
     private function purgeOldVersions()
     {
         $keep = isset($this->keepOldVersions) ? $this->keepOldVersions : 0;
-        $count = $this->versions()->count();
-
-        if ((int)$keep > 0 && $count > $keep) {
-            $oldVersions = $this->versions()
-                ->latest()
-                ->take($count)
-                ->skip($keep)
-                ->get()
-                ->each(function ($version) {
-                $version->delete();
-            });
+
+        if ((int)$keep > 0) {
+            $count = $this->versions()->count();
+
+            if ($count > $keep) {
+                $oldVersions = $this->versions()
+                    ->latest()
+                    ->take($count)
+                    ->skip($keep)
+                    ->get()
+                    ->each(function ($version) {
+                    $version->delete();
+                });
+            }
         }
     }