Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Privacy Manifest for iOS 17 #23

Merged
merged 1 commit into from
May 23, 2024
Merged

feat: Add Privacy Manifest for iOS 17 #23

merged 1 commit into from
May 23, 2024

Conversation

einsteinx2
Copy link
Contributor

Summary

  • Add privacy manifest to kit
  • Update Adobe Media SDKs to latest 5.0.0 version to get their privacy manifests
  • Fixed some header import issues I discovered
  • Raised deployment target to iOS 12 to match Adobe

Testing Plan

  • Was this tested locally? If not, explain why.
  • E2E tested with both Cocoapods and SPM test app up to Adobe Cloud and confirmed receipt of events.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@einsteinx2 einsteinx2 force-pushed the feat/6413-improve-privacy-manifest-support branch from 5b4da60 to 911dbae Compare May 23, 2024 15:45
BrandonStalnaker
BrandonStalnaker approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einsteinx2 einsteinx2 merged commit 911ad2c into development May 23, 2024
3 checks passed
@einsteinx2 einsteinx2 deleted the feat/6413-improve-privacy-manifest-support branch May 23, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@einsteinx2 @BrandonStalnaker