-
Notifications
You must be signed in to change notification settings - Fork 218
Conversation
What does GV need to do, I'm not aware of anything. |
If we wanna confirm if WebXR selection event work (https://immersive-web.github.io/webxr-samples/input-selection.html). We need XRSession API [1] be landed to Gecko first, and check below
events work properly. |
You implied you were waiting on GV work. But you just meant waiting for things to land in gecko then? |
68cc832
to
12e8d57
Compare
I am going to give a commit for Oculus and Wave controllers button & axis mapping adjustment for WebXR. |
12e8d57
to
7d3843e
Compare
We need to wait for Bug 1624762 lands. |
7d3843e
to
64e9a0a
Compare
00c43aa
to
e911b8e
Compare
Added PicoVR controllers support, and Bug 1624762 is under review process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested Hello WebXR and the trigger click is not working (the grip works). It's the opposite in Oculus Browser, are the grip and the trigger inverted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected in Oculus. I didn't have 1624762 applied...
Updated GV because Bug 1624762 is landed. We can start to review it. |
8b40458
to
3af70f3
Compare
Hello XR doesn't work with the Pico G2 4K, head is in the floor. With the Neo2 it seems like you can't leave the spray paint area because teleport stops working. |
Okay, let's land this and fix the G2 in a follow up. |
3af70f3
to
2f839d4
Compare
Bump GV to 77.0.20200418094905. I notice we should remove |
The Pico G2 controller is still coming out of the head in Hello WebXR. |
@bluemarvin have you tested if the controller is also coming out of the head on the threejs examples? |
I gave a fix for positionEmulated in both of Gecko of FxR. Unfortunately, I don't have a 3DOF device on my hand. I need a volunteer to help me verify it. |
I did test ball shooter and the controller came out of the head there as well. Obviously works fine in Oculus browser on the Go. |
Do I need to build a local version of GeckoView or did it already land in nightly? |
Nevermind, I see. |
I tested it on the G2 and the controller is still coming from the eyes. |
947587b
to
aeb3361
Compare
It should be all right now if I did a right thing on my Go-like Quest. |
I have fixed the G2 K4 problem. We need to apply the elbow transform for immersive mode. WebXR needs it applied when using |
…he WebXR interstitial
I found that select and squeeze actions where still triggered when clicking on the WebXR interstitial, so e.g. in Hello WebXR you could transport to a experience without wanting it. Already fixed |
Fixes #2237 and #2095.
I have checked it works properly in my local but I am still waiting for WebXRSession and WebXRInputSource implementation from GeckoView. We might can merge it first? Or we need to wait for WebXR works in GV?
I will be away for a couple of weeks. If there are some WebXR progress from GV, maybe someone from our team can continue to work on this.