Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

L10n fixes #1601

Merged
merged 2 commits into from
Aug 21, 2019
Merged

L10n fixes #1601

merged 2 commits into from
Aug 21, 2019

Conversation

keianhzo
Copy link
Contributor

@keianhzo keianhzo commented Aug 19, 2019

Fixes mozilla-l10n/android-l10n#62 L10n fixes

Copy link

@Delphine Delphine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change (since that string was already exposed and translated), the rest LGTM. thanks

@@ -731,7 +731,7 @@
speech-to-text recognition. -->
<string name="voice_search_tooltip">Voice Search</string>

<!-- This string is for the tooltip that appears upon hovering the 'User Agent' button in the
<!-- This string is for the tooltip that appears upon hovering the 'Request desktop site' button in the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial comment and string that landed was "Switch User Agent". Since this changes, there should be a new String ID to reflect that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Delphine Should be ok no

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks!

@@ -731,7 +731,7 @@
speech-to-text recognition. -->
<string name="voice_search_tooltip">Voice Search</string>

<!-- This string is for the tooltip that appears upon hovering the 'User Agent' button in the
<!-- This string is for the tooltip that appears upon hovering the 'Request desktop site' button in the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks!

@bluemarvin bluemarvin merged commit fe39b27 into master Aug 21, 2019
@bluemarvin bluemarvin deleted the L10n_fixes branch August 26, 2019 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants