-
Notifications
You must be signed in to change notification settings - Fork 218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change (since that string was already exposed and translated), the rest LGTM. thanks
@@ -731,7 +731,7 @@ | |||
speech-to-text recognition. --> | |||
<string name="voice_search_tooltip">Voice Search</string> | |||
|
|||
<!-- This string is for the tooltip that appears upon hovering the 'User Agent' button in the | |||
<!-- This string is for the tooltip that appears upon hovering the 'Request desktop site' button in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial comment and string that landed was "Switch User Agent". Since this changes, there should be a new String ID to reflect that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Delphine Should be ok no
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks!
@@ -731,7 +731,7 @@ | |||
speech-to-text recognition. --> | |||
<string name="voice_search_tooltip">Voice Search</string> | |||
|
|||
<!-- This string is for the tooltip that appears upon hovering the 'User Agent' button in the | |||
<!-- This string is for the tooltip that appears upon hovering the 'Request desktop site' button in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks!
Fixes mozilla-l10n/android-l10n#62 L10n fixes