Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

L10n fixes #1601

Merged
merged 2 commits into from
Aug 21, 2019
+5 −8
Merged

L10n fixes #1601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cc605a
L10n fixes
keianhzo Aug 19, 2019
4a4deef
Replace request desktop tooltip string
keianhzo Aug 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/res/layout/navigation_url.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
android:id="@+id/uaModeButton"
style="@style/urlBarIconTheme"
android:src="@drawable/ic_icon_ua_default"
android:tooltipText="@string/user_agent_tooltip"
android:tooltipText="@string/request_dekstop_site_tooltip"
android:tint="@color/fog" />

<org.mozilla.vrbrowser.ui.views.UIButton
Expand Down
11 changes: 4 additions & 7 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,9 +731,9 @@
speech-to-text recognition. -->
<string name="voice_search_tooltip">Voice Search</string>

<!-- This string is for the tooltip that appears upon hovering the 'User Agent' button in the
<!-- This string is for the tooltip that appears upon hovering the 'Request desktop site' button in the
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial comment and string that landed was "Switch User Agent". Since this changes, there should be a new String ID to reflect that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Delphine Should be ok no

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks!

browser's navigation bar. The button it labels, when pressed, change the currently used user agent. -->
<string name="user_agent_tooltip">Request desktop site</string>
<string name="request_dekstop_site_tooltip">Request desktop site</string>

<!-- This string is for the tooltip that appears upon hovering the 'Clear' button in the
browser's navigation bar. The button it labels, when pressed, clears the navigation bar text. -->
Expand Down Expand Up @@ -855,9 +855,6 @@
<!-- This string is displayed as the message body of a dialog displayed when poor web page performance has been detected and the page has been unloaded to restore performance. -->
<string name="performance_message">Try reducing the window size to improve performance. Unblocking this page may crash your app.</string>

<!-- This string is displayed anywhere where we need to display the "Default" string by itself. -->
<string name="tag_default">Default</string>

<!-- This string is displayed in the title of the Voice Search samples collect dialog. That dialog is shown the first time
a user tries to use the voice search. -->
<string name="voice_samples_collect_dialog_title">Allow Firefox to Anonymously Collect Voice Samples?</string>
Expand All @@ -867,11 +864,11 @@
<string name="voice_samples_collect_dialog_description">Your data is always anonymous and protected under our Personal Data Promise. We collect voice samples to improve the experience and performance of our products. You’ll always be able to use voice search, even if you don’t allow collection.&lt;a href="privacy">Learn More&lt;/a></string>

<!-- This string is displayed in the button of the Voice Search samples collect dialog.
When clicked the user opts out from the voice data collection. -->
When clicked the user opts in to the voice data collection. -->
<string name="voice_samples_collect_dialog_allow">Allow</string>

<!-- This string is displayed in the button of the Voice Search samples collect dialog.
When clicked the user opts in for the voice data collection. -->
When clicked the user opts out of the voice data collection. -->
<string name="voice_samples_collect_dialog_do_not_allow">Don’t Allow</string>

<!-- This string is displayed in the content language list in front of the system default language in between parenthesis -->
Expand Down