Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

If resize is cancelled, resize back to the screen size it had before entering resize mode. #1411

Merged
merged 1 commit into from
Jul 19, 2019
Merged

If resize is cancelled, resize back to the screen size it had before entering resize mode. #1411

merged 1 commit into from
Jul 19, 2019

Conversation

MortimerGoro
Copy link
Contributor

Fixes #1391

bluemarvin
bluemarvin reviewed Jul 19, 2019
View reviewed changes
app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/NavigationBarWidget.java

enum ResizeAction {
KEEP_SIZE,
RESTORE_SIZE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using enum now? Do they no longer bloat the APK? We are now using both enum and final int in different places. final int I guess makes sense for JNI calls. Not sure if there is a benefit to enum?

@bluemarvin bluemarvin merged commit f08ecc4 into master Jul 19, 2019
@bluemarvin bluemarvin mentioned this pull request Jul 19, 2019
Closed
@bluemarvin bluemarvin deleted the resize_back branch July 19, 2019 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@keianhzo keianhzo keianhzo approved these changes

@bluemarvin bluemarvin bluemarvin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The resize dimensions are wrongly saved when the back button on the controller is pressed
3 participants
@MortimerGoro @bluemarvin @keianhzo