Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

New window size is save even when not used #1434

Closed
bluemarvin opened this issue Jul 19, 2019 · 2 comments · Fixed by #1465
Closed

New window size is save even when not used #1434

bluemarvin opened this issue Jul 19, 2019 · 2 comments · Fixed by #1465
Assignees
@MortimerGoro
Labels
bug This issue is a software or functional defect [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Milestone
v1.4

Comments

@bluemarvin
Copy link
Contributor

Hardware

All

Steps to Reproduce

  1. Click window resize button
  2. Click 0.5x button
  3. Press back button to cancel resize and restore window size
  4. Kill FxR
  5. Launch FxR

Current Behavior

Window size is 0.5x

Expected Behavior

Window size should be same as when FxR was killed.

Regression

Regressed by #1411
@bluemarvin bluemarvin added bug This issue is a software or functional defect regression labels Jul 19, 2019
@bluemarvin bluemarvin added this to the v1.4 milestone Jul 19, 2019
Closed
@philip-lamb philip-lamb added the P3 Backlog label Jul 24, 2019
@philip-lamb
Copy link
Contributor

@MortimerGoro Is this covered in the current window size work?

@MortimerGoro MortimerGoro mentioned this issue Jul 26, 2019
Merged
@philip-lamb philip-lamb removed the P3 Backlog label Jul 26, 2019
@Softvision-GeluHaiduc
Copy link

I have verified that this issue is no longer reproducible with the latest FirefoxReality 1.4-32072251 installed on the Oculus Go headset.
Now, the window size that was not saved is not used after a restart of the browser.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MortimerGoro MortimerGoro

Labels
bug This issue is a software or functional defect [QA]:Verified fixed Label for QA to mark verified fixed issues regression
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Do not save window size when resize is cancelled MozillaReality/FirefoxReality
4 participants
@bluemarvin @MortimerGoro @philip-lamb @Softvision-GeluHaiduc