-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump deps to latest #2235
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Xuanwo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2235 +/- ##
===========================================
+ Coverage 30.91% 51.16% +20.25%
===========================================
Files 53 55 +2
Lines 20112 20749 +637
Branches 9755 9900 +145
===========================================
+ Hits 6217 10617 +4400
- Misses 7922 8085 +163
+ Partials 5973 2047 -3926 ☔ View full report in Codecov by Sentry. |
Hi, @sylvestre, I think it's time for us to cut off a new release. I expect to see #2234 happen in |
Hi @Xuanwo, Should we resolve conflicts for next merging? |
yes, please fix the conflicts |
which = { version = "6", default-features = false } | ||
zip = { version = "0.6", default-features = false } | ||
zip = { version = "2", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the problem from #2227 still persist?
If yes, please, try to find the 2.x.y version, that works.
The similar issue on the original repository: zip-rs/zip2#231
This PR will bump deps to latest.