Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added partial support for meta.com and instagram.com #505

Merged
merged 2 commits into from
May 21, 2024

Conversation

Greg-21
Copy link
Contributor

@Greg-21 Greg-21 commented Apr 24, 2024

In this pull request, I modified the existing rule for the standard cookie banner used by Meta on a large part of their websites to enable automatic handling of this banner by the Firefox cookie banner blocker on some of the meta.com and instagram.com subdomains that use it.

Also, just to make this extra clear and for future reference, I'm adding meta.com and instagram.com to the rule list not to add support for the main banners on both of these websites but to make about.meta.com and about.instagram.com supported respectively (and probably other subdomains I missed).

Resolves #476
Resolves #499

@Greg-21 Greg-21 requested a review from a team as a code owner April 24, 2024 19:40
@abhishekmadan30
Copy link
Contributor

could you give some examples of those subdomains

@Trikolon Trikolon merged commit 4af07d3 into mozilla:main May 21, 2024
1 check passed
@Greg-21 Greg-21 deleted the rule-meta-com-instagram-com branch July 8, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About.instagram.com is an unsupported website Support for some meta.com web pages could be added
3 participants