Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rule for gdpr.twitter.com #497

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Fix rule for gdpr.twitter.com #497

merged 2 commits into from
Apr 17, 2024

Conversation

metametapod
Copy link
Contributor

Example URL

https://gdpr.twitter.com

Screenshot

Screenshot 2024-04-14 at 15 20 58

Tested on Firefox 125.0b9

Tried to add a rule specific to the subdomain (not sure if it applies to others), but it wouldn't apply due to existing twitter.com rule.

@metametapod metametapod requested a review from a team as a code owner April 14, 2024 22:29
Trikolon
Trikolon approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@Trikolon Trikolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We apply cookie banner rules on base domain level currently (eTLD+1). We might add subdomain support in the future. Adding this cookie for the entire basedomain is unlikely to break anything so let's do it.

@Trikolon Trikolon merged commit 6b65308 into mozilla:main Apr 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trikolon Trikolon Trikolon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metametapod @Trikolon