Added a new rule for Eclipse websites #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekmadan30
approved these changes
Dec 5, 2023
|
I am currently looking into adding more CMPs, I can add this one to my list too. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, I added a new rule for Eclipse websites and websites of Eclipse-affiliated or owned projects that display a cookie banner.
One important note, the cookie banner used by Eclipse on their various websites appears to be some kind of cookie consent manager from some CMP. I presume this is a slightly customized Cookie Consent by Insites (https://web.archive.org/web/20190520103530/https://cookieconsent.insites.com/ ).
I would consider converting this site-specific rule to a global rule, but the use of this CMP by various websites has a few catches, and it won't be as easy as it might seem. Currently, I don't have enough time to get into it.
Resolves #340