Added a new rule for Dell websites #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rule I initially planned to commit with all the other tech company websites in #333, but it looks like it might be a (heavily modified?) cookie consent manager from some CMP.
The use of the
.cc-window,.cc-dismiss, and.cc-allowclasses might suggest that this is the Cookie Consent by Insites (https://web.archive.org/web/20190520103530/https://cookieconsent.insites.com/ ), but both the JS code responsible for handling cookies is completely different, and the design of the cookie banner itself also stands out. This can't be it, I think.For the time being, I propose adding this Dell rule to the list, and perhaps there will be time in the future to further investigate this matter.
Resolves #338