Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rule for golem.de #319

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Added rule for golem.de #319

merged 1 commit into from
Nov 30, 2023

Conversation

scharmach
Copy link
Contributor

This could also be expanded to:

{
  "id": "683710CF-F5E6-4707-BFB0-A69F133FC35C",
  "domains": ["golem.de"],
  "click": {
    "optIn": ".sp_choice_type_11",
    "presence": ".message-container > #notice",
    "runContext": "child"
  },
  "cookies": {
    "optIn": [
      {
        "name": "golem_consent20",
        "value": "cmp|220101"
      }
    ]
  }
}

@scharmach scharmach requested a review from a team as a code owner November 26, 2023 16:19
@scharmach scharmach mentioned this pull request Nov 26, 2023
Closed
abhishekmadan30
abhishekmadan30 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@abhishekmadan30 abhishekmadan30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Thanks !

@scharmach @abhishekmadan30
Added rule for golem.de
a083c7d 
This could also be expanded to:

{
  "id": "683710CF-F5E6-4707-BFB0-A69F133FC35C",
  "domains": ["golem.de"],
  "click": {
    "optIn": ".sp_choice_type_11",
    "presence": ".message-container > #notice",
    "runContext": "child"
  },
  "cookies": {
    "optIn": [
      {
        "name": "golem_consent20",
        "value": "cmp|220101"
      }
    ]
  }
}
@abhishekmadan30
Copy link
Contributor

I checked the cookie rule you mentioned above and it seem to remove the banner.

@abhishekmadan30 abhishekmadan30 merged commit a587666 into mozilla:main Nov 30, 2023
1 check passed
cadeyrn pushed a commit to cadeyrn/cookie-banner-rules-list that referenced this pull request Dec 3, 2023
@scharmach @cadeyrn
Added rule for golem.de (mozilla#319)
ab12173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekmadan30 abhishekmadan30 abhishekmadan30 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scharmach @abhishekmadan30