Add rule for yahoo.com, engadget.com, and techcrunch.com #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how to resolve the test failure. There's a duplicate rule for |
|
Thanks for the PR! Unfortunately this can't be merged just yet. We're still evaluating internally whether we can handle GPC banners using the cookie banner handling mechanism. |
|
I've confirmed with the team that we can't handle GPC banners as part of cookie banner handling at this point. When users opt-in to our cookie banner handling they don't necessarily opt into us handling GPC banners. We'll look into handling these banners in the future though, especially if they become more popular. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example URLs
Fixes #215 (includes additional steps to reproduce).
Screenshot
Tested on Firefox 120.0b9