Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info about OpenSSL proxy option to cipherscan script. #131

Merged
merged 2 commits into from
Jan 13, 2017
Merged

Added info about OpenSSL proxy option to cipherscan script. #131

merged 2 commits into from
Jan 13, 2017

Conversation

castillar
Copy link

Per issue #129.

@@ -250,6 +250,8 @@ Some useful OpenSSL options:
that require turning TLS after initial protocol specific
hello
-servername name Request SNI support for connections
-proxy proxyhost:port Connect to the scan target via specified proxy
(req. OpenSSL 1.0.x)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it really work in all 1.0.x branches? I don't see it listed in 1.0.2j s_client -help message....

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, this is interesting. The copy of OpenSSL supplied with cipherscan works with the -proxy option, but a local copy of 1.0.2j doesn't work with it. May have to change that to something like "Requires supplied OpenSSL or >1.1.0"? Trying to figure out exactly where this got introduced to OpenSSL is a challenge because the feature appears to predate their migration to Git (at least, I couldn't find anything about it in their repository).

@floatingatoll
Copy link
Contributor

floatingatoll commented Dec 2, 2016 via email

@castillar
Copy link
Author

Fixed! Modified the version message to specify 1.1.0 or bundled OpenSSL. Thanks to @floatingatoll for the pointer--that'll come in handy!

@jvehent jvehent merged commit 1f2846d into mozilla:master Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants