Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needinfo the author or reviewer for inactive revisions on Phabricator #2417

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Needinfo the author or reviewer for inactive revisions on Phabricator #2417

wants to merge 19 commits into from
+388 −0

Commits on Jun 3, 2024

  1. Initial (incomplete) inactive_revision rule commit

    @benjaminmah
    benjaminmah committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    dd98111 View commit details
    Browse the repository at this point in the history

  2. Updated function to find the author of the last action

    @benjaminmah
    benjaminmah committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b2fc12f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Added functions from inactive_reviewer.py

    @benjaminmah
    benjaminmah committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e7517fc View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Added functions from inactive_reviewer.py to maintain similar funct… 

    …ionality
    @benjaminmah
    benjaminmah committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    960fca7 View commit details
    Browse the repository at this point in the history

  2. Removed print statement

    @benjaminmah
    benjaminmah committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    f3716bb View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Initial templates for inactive_revision.py rule

    @benjaminmah
    benjaminmah committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    7e17ee3 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Added separate needinfo comments depending on who is being needinfo'ed

    @benjaminmah
    benjaminmah committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    20210a1 View commit details
    Browse the repository at this point in the history

  2. Removed old needinfo template

    @benjaminmah
    benjaminmah committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ab3df86 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Fixed _get_revisions_with_inactive_action() to focus on inactive pa… 

    …tches rather than inactive reviewers
    @benjaminmah
    benjaminmah committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    89b50ac View commit details
    Browse the repository at this point in the history

  2. Removed initialization of patch_activity_months arg

    @benjaminmah
    benjaminmah committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d7c6689 View commit details
    Browse the repository at this point in the history

  3. Edited email template

    @benjaminmah
    benjaminmah committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d736546 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Replaced double negation with all

    @benjaminmah
    benjaminmah committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    f739f18 View commit details
    Browse the repository at this point in the history

  2. Removed returning "other" case when finding last action

    @benjaminmah
    benjaminmah committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    9dbb76a View commit details
    Browse the repository at this point in the history

  3. Added filtering out resigned reviewers

    @benjaminmah
    benjaminmah committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    1c07ddd View commit details
    Browse the repository at this point in the history

  4. Added column for needinfo_user in email template

    @benjaminmah
    benjaminmah committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    1c83ba3 View commit details
    Browse the repository at this point in the history

  5. Added column for needinfo_user

    @benjaminmah
    benjaminmah committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e34cd1f View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Added max_actions to the inactive_revision rule

    @benjaminmah
    benjaminmah committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    3efbfd1 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Replaced Dict and List with dict and list

    @benjaminmah
    benjaminmah committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    8172791 View commit details
    Browse the repository at this point in the history

  2. Reversed condition and added continue

    @benjaminmah
    benjaminmah committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    69385c6 View commit details
    Browse the repository at this point in the history