Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNTOR-3815 - Data broker manual removal integration #5326

Merged
merged 6 commits into from
Nov 21, 2024
Merged

MNTOR-3815 - Data broker manual removal integration #5326

merged 6 commits into from
Nov 21, 2024

Conversation

codemist
Copy link
Collaborator

References:

Jira: MNTOR-
Figma:

Description

Screenshot (if applicable)

Not applicable.

How to test

Checklist (Definition of Done)

  • Localization strings (if needed) have been added.
  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • I've added a unit test to test for potential regressions of this bug.
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
  • All acceptance criteria are met.
  • Jira ticket has been updated (if needed) to match changes made during the development process.
  • Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

@codemist codemist requested a review from flozia November 20, 2024 19:18
codemist
codemist commented Nov 20, 2024
View reviewed changes
...dashboard/fix/data-broker-profiles/removal-under-maintenance/RemovalUnderMaintenanceView.tsx
Comment on lines +98 to +102
// eslint-disable-next-line @typescript-eslint/no-misused-promises
onMarkAsResolved={() => {
handleManualRemovalChange().catch((error) => {
console.error("Error during manual removal change:", error);
});
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flozia Trying to determine if there's a workaround here. Do you have any suggestions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codemist A workaround as in not needing eslint-disable-next-line or is there an issue with the error handling?

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5326-mgjlpikfea-uk.a.run.app

Base automatically changed from MNTOR-3815 to mntor-3378 November 20, 2024 21:00
@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5326-mgjlpikfea-uk.a.run.app

@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5326-mgjlpikfea-uk.a.run.app

1 similar comment
@github-actions GitHub Actions
Copy link

Preview URL 🚀 : https://blurts-server-pr-5326-mgjlpikfea-uk.a.run.app

@codemist codemist merged commit 3bab78b into mntor-3378 Nov 21, 2024
7 checks passed
@codemist codemist deleted the MNTOR-3815-integration branch November 21, 2024 19:17
@github-actions GitHub Actions
Copy link

Cleanup completed - database 'blurts-server-pr-5326' destroyed, cloud run service 'blurts-server-pr-5326' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flozia flozia Awaiting requested review from flozia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codemist @flozia @mansaj @rhelmer