MNTOR-3378 - Data broker manual removal 🔴 DO NOT MERGE - Waiting for regression testing 🔴 #5287

codemist · 2024-11-04T18:36:43Z

References:

Jira: MNTOR-3378
Figma: https://www.figma.com/design/DTbmXzCQCw2PxXpHQW8yfW/Monitor-MVP-Enhancements?node-id=3809-6501&t=EniBV7WqvPVnuivk-4

Path: /user/dashboard/fix/data-broker-profiles/removal-under-maintenance

Description

Screenshot (if applicable)

Not applicable.

How to test

Checklist (Definition of Done)

Localization strings (if needed) have been added.
Commits in this PR are minimal and have descriptive commit messages.
I've added or updated the relevant sections in readme and/or code comments
I've added a unit test to test for potential regressions of this bug.
If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
Product Owner accepted the User Story (demo of functionality completed) or waived the privilege.
All acceptance criteria are met.
Jira ticket has been updated (if needed) to match changes made during the development process.
Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.

github-actions · 2024-11-04T18:53:04Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

codemist · 2024-11-04T19:20:09Z

src/app/functions/universal/scanResult.ts

+  | "removed"
+  | "removal_under_maintenance";


@rhelmer I believe this would be our first time consuming this endpoint for the manual data broker removal feature.

github-actions · 2024-11-04T19:23:10Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-04T19:36:37Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-06T21:02:42Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

github-actions · 2024-11-12T19:01:56Z

Preview URL 🚀 : https://blurts-server-pr-5287-mgjlpikfea-uk.a.run.app

codemist · 2024-11-26T16:02:51Z

Fixed that linter error here 32831a1 @flozia

src/app/components/client/exposure_card/ScanResultCard.tsx

flozia

Thanks for addressing my previous comments and making all the updates after aligning with UX!

I’m already submitting my “in progress” review to not block you waiting on reviews. At the moment I’m not able to access all views and test the functionality fully. I’m having issues to access the page /user/dashboard/fix/data-broker-profiles/removal-under-maintenance. I’ve tried adding mock broker results and also modifying the query in getScanResultsWithBrokerUnderMaintenance to get results back. Could you update the description with some guidance on how to test this best?

src/app/functions/server/getRelevantGuidedSteps.ts

src/db/tables/onerep_scans.ts

...ated)/user/(dashboard)/dashboard/fix/data-broker-profiles/removal-under-maintenance/page.tsx

...dashboard/fix/data-broker-profiles/removal-under-maintenance/RemovalUnderMaintenanceView.tsx

src/app/components/client/exposure_card/ExposureCardDataClass.tsx

src/app/components/client/exposure_card/ScanResultCard.tsx

codemist · 2024-11-27T14:33:20Z

@flozia You should only be seeing a list if you're premium.

codemist · 2024-11-28T02:34:15Z

...ated)/user/(dashboard)/dashboard/fix/data-broker-profiles/removal-under-maintenance/page.tsx

+  if (!session?.user?.subscriber?.id || !hasPremium(session.user)) {
+    redirect("/user/dashboard");
+  }


This feature should only be available to Plus users - I also added this logic in isEligibleForStep in getRelevantGuidedSteps.ts.

codemist · 2024-11-28T02:39:27Z

src/app/components/client/Button.tsx

+    <div className={`${styles.ldsRing} ${variant ? styles[variant] : ""}`}>
      <VisuallyHidden>{l10n.getString("loading-accessibility")}</VisuallyHidden>
-      <div></div>
-      <div></div>
-      <div></div>
-      <div></div>
+      <div className={variant ? styles[variant] : ""}></div>
+      <div className={variant ? styles[variant] : ""}></div>
+      <div className={variant ? styles[variant] : ""}></div>
+      <div className={variant ? styles[variant] : ""}></div>


Added this here to style the fill colour of the loading ring depending on the button variant.

codemist added 3 commits November 4, 2024 11:28

fix ui

dec0aa7

apply ui changes tto scanresultcard

1bd3c2d

apply styling to button

1ab2f5d

add removal under maintenance status

a22d17f

codemist commented Nov 4, 2024

View reviewed changes

codemist requested a review from rhelmer November 4, 2024 19:20

change cta label and write test

e7d8016

codemist added 2 commits November 4, 2024 14:53

add new removal under maintenance page

98a5cd4

test exposure card in new view data broker page

2552e73

codemist added 9 commits November 6, 2024 20:18

change terminology ot data broker

27635ae

make new scan result component for resolution flow

b0e33d2

ui fixes

fc50d36

add header

517feb7

add header string

dc27aa7

add box shadow

24cb2c7

add estimated time of removal

9f47831

add removal instructions view

23439bd

ui tweaks

b9a31d3

codemist marked this pull request as ready for review November 12, 2024 18:53

codemist requested a review from flodolo as a code owner November 12, 2024 18:53

codemist added the 🛑 Do Not Merge Do not merge this PR, even if approved. label Nov 12, 2024

codemist added 2 commits November 12, 2024 13:55

rremove ispremium force

7e39450

remove commented out code

b8c87c0

codemist force-pushed the mntor-3378 branch from 8ff9086 to b8c87c0 Compare November 12, 2024 18:55

codemist requested a review from flozia November 12, 2024 18:56

fix e2e tests

cbb550b

codemist force-pushed the mntor-3378 branch from d20a58e to cbb550b Compare November 25, 2024 21:47

roll back string change

c50090e

codemist force-pushed the mntor-3378 branch from da67c60 to c50090e Compare November 25, 2024 21:50

fix pbroken test

578505b

codemist force-pushed the mntor-3378 branch from 0bf7381 to 578505b Compare November 26, 2024 15:34

codemist requested a review from flozia November 26, 2024 15:47

remove typescript linter

32831a1

codemist force-pushed the mntor-3378 branch from 6c45a44 to 32831a1 Compare November 26, 2024 15:55

fix completion order

b18ad97

codemist force-pushed the mntor-3378 branch from 5b4f4ee to b18ad97 Compare November 26, 2024 16:11

codemist added 3 commits November 26, 2024 12:26

add mmanual resolution praise

b933b17

dadd dashboard description for fixed state

94c6e2d

add unit tests

19a4554

codemist commented Nov 26, 2024

View reviewed changes

src/app/components/client/exposure_card/ScanResultCard.tsx Show resolved Hide resolved

codemist added 3 commits November 26, 2024 15:54

fix

c219ccc

add toast error

126d164

add string

6c7a59c

flozia reviewed Nov 27, 2024

View reviewed changes

codemist added 4 commits November 27, 2024 09:42

fixes

9b7fb52

use trycatch

4768651

show loader in white on hover

442575d

remove exposureicon style

5449594

codemist added 🛑 Do Not Merge Do not merge this PR, even if approved. and removed 🛑 Do Not Merge Do not merge this PR, even if approved. labels Nov 27, 2024

codemist changed the title ~~MNTOR-3378 - Data broker manual removal~~ MNTOR-3378 - Data broker manual removal 🔴 DO NOT MERGE - Waiting for regression testing 🔴 Nov 27, 2024

codemist commented Nov 28, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MNTOR-3378 - Data broker manual removal 🔴 DO NOT MERGE - Waiting for regression testing 🔴 #5287

MNTOR-3378 - Data broker manual removal 🔴 DO NOT MERGE - Waiting for regression testing 🔴 #5287

codemist commented Nov 4, 2024 •

edited

Loading

github-actions bot commented Nov 4, 2024

codemist Nov 4, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 12, 2024

codemist commented Nov 26, 2024

flozia left a comment

codemist commented Nov 27, 2024

codemist Nov 28, 2024 •

edited

Loading

codemist Nov 28, 2024

MNTOR-3378 - Data broker manual removal 🔴 DO NOT MERGE - Waiting for regression testing 🔴 #5287

Are you sure you want to change the base?

MNTOR-3378 - Data broker manual removal 🔴 DO NOT MERGE - Waiting for regression testing 🔴 #5287

Conversation

codemist commented Nov 4, 2024 • edited Loading

References:

Description

Screenshot (if applicable)

How to test

Checklist (Definition of Done)

github-actions bot commented Nov 4, 2024

codemist Nov 4, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 12, 2024

codemist commented Nov 26, 2024

flozia left a comment

Choose a reason for hiding this comment

codemist commented Nov 27, 2024

codemist Nov 28, 2024 • edited Loading

Choose a reason for hiding this comment

codemist Nov 28, 2024

Choose a reason for hiding this comment

codemist commented Nov 4, 2024 •

edited

Loading

codemist Nov 28, 2024 •

edited

Loading