Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-10575 Protection panel: Clear Cookies + Site Data / Design QA #23226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petruSt24
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Changed the url into the long version and added a simple toast after clearing cookies

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

Copy link
Collaborator

@MattLichtenstein MattLichtenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the designs, it seems like pressing "Clear" on the "Clear cookies and site data" sheet should dismiss the sheet and the toast should be presented over the webpage, instead of within the ETP sheet.

Actual Expected

@cyndichin cyndichin removed their request for review November 20, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants