Import fenix quarantine #812
Conversation
mozilla-pontoon
force-pushed
the
fenix_l10n_updates
branch
from
22bfd0f to
21ac3a5
Compare
| <!-- Bookmark snackbar message for deleting a single item. Parameter is the title of the item being deleted --> | ||
| <string name="bookmark_delete_single_item">Deleted %s</string> | ||
| <!-- Bookmark snackbar message for deleting multiple items. Parameter is the number of items being deleted --> | ||
| <string name="bookmark_delete_multiple_items">Deleted %s items</string> |
There was a problem hiding this comment.
We still don't handle plural support properly, please update the string to:
Deleted items: %s
There was a problem hiding this comment.
Yes, I approve this update to line 1233 and will update the Figma.
| <!-- Bookmark snackbar message for deleting multiple items. Parameter is the number of items being deleted --> | ||
| <string name="bookmark_delete_multiple_items">Deleted %s items</string> | ||
| <!-- Bookmark folder deletion dialog title. Parameter is the number of items being deleted --> | ||
| <string name="bookmark_delete_folder_dialog_title">Are you sure you want to delete %s items?</string> |
There was a problem hiding this comment.
We're going to need a new string here since we don't handle plurals correctly
CC @ewachowiak for insights
There was a problem hiding this comment.
For line 1237, I notice that we say "3 selected" elsewhere in the copy and are able to handle this plural correctly. Would it work to say "Are you sure you want to delete 3 selected items?" If not, I think we should say "Are you sure you want to delete multiple items?"
There was a problem hiding this comment.
If this string is about 3 selected items, we can use that. If it's anything else than 3, we would have to use "multiple"
There was a problem hiding this comment.
This is a "variable" string, so yes we will need to say "Are you sure you want to delete multiple items?" I will update the Figma.
mozilla-pontoon
force-pushed
the
fenix_l10n_updates
branch
6 times, most recently
from
ca213d7 to
edc0b05
Compare
| @@ -298,6 +294,18 @@ | |||
| <string name="browser_menu_tools">Tools</string> | |||
| <!-- Content description (not visible, for screen readers etc.): Back button for all menu redesign sub-menu --> | |||
| <string name="browser_menu_back_button_content_description">Back to main menu</string> | |||
| <!-- Content description (not visible, for screen readers etc.) for bottom sheet handlebar. The placeholder will be updated by, for example, "Main menu". --> | |||
| <string name="browser_menu_handlebar_content_description">Close %1$s sheet</string> | |||
There was a problem hiding this comment.
This approach won't work because it doesn't consider how different languages handle grammatical gender. In many languages, the gender of words (such as masculine, feminine, or neuter) can change how sentences are structured. Right now, the placeholder is only using one version, but we actually need separate strings for each case to account for these gender differences in translation.
There was a problem hiding this comment.
@boek After giving this some more thought, it's improbable that some languages would have to change gender since the word "sheet" is the noun and remains this way throughout current existing strings.
However, it's still highly recommendable to have individual strings in this specific case (and since we're only talking about a few strings). For example, weird capitalization might happen when "stitching" these strings back together (see how "Main menu" and "Extensions menu" strings are both capitalized, but they will end up replacing the placeholder in the middle of the browser_menu_handlebar_content_description string, which will result in awkward looking strings).
mozilla-pontoon
force-pushed
the
fenix_l10n_updates
branch
2 times, most recently
from
d99f31c to
290bfde
Compare
| @@ -298,6 +294,18 @@ | |||
| <string name="browser_menu_tools">Tools</string> | |||
| <!-- Content description (not visible, for screen readers etc.): Back button for all menu redesign sub-menu --> | |||
| <string name="browser_menu_back_button_content_description">Back to main menu</string> | |||
| <!-- Content description (not visible, for screen readers etc.) for bottom sheet handlebar. The placeholder will be updated by, for example, "Main menu". --> | |||
| <string name="browser_menu_handlebar_content_description">Close %1$s sheet</string> | |||
There was a problem hiding this comment.
@boek After giving this some more thought, it's improbable that some languages would have to change gender since the word "sheet" is the noun and remains this way throughout current existing strings.
However, it's still highly recommendable to have individual strings in this specific case (and since we're only talking about a few strings). For example, weird capitalization might happen when "stitching" these strings back together (see how "Main menu" and "Extensions menu" strings are both capitalized, but they will end up replacing the placeholder in the middle of the browser_menu_handlebar_content_description string, which will result in awkward looking strings).
mozilla-pontoon
force-pushed
the
fenix_l10n_updates
branch
3 times, most recently
from
498aa8d to
6c5c586
Compare
mozilla-pontoon
force-pushed
the
fenix_l10n_updates
branch
from
6c5c586 to
b6203b7
Compare
Import fenix quarantine