Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fenix quarantine #793

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Import fenix quarantine #793

merged 1 commit into from
Aug 29, 2024

Conversation

mozilla-pontoon
Copy link
Collaborator

Import fenix quarantine

@mozilla-pontoon mozilla-pontoon requested a review from a team as a code owner August 15, 2024 15:12
@mozilla-pontoon mozilla-pontoon added the l10n-bot Pull request created by automation label Aug 15, 2024
@mozilla-pontoon mozilla-pontoon force-pushed the fenix_l10n_updates branch 4 times, most recently from 5bf9151 to 2893b2c Compare August 21, 2024 15:12
@@ -205,6 +205,8 @@
<string name="browser_menu_manage_extensions">Manage extensions</string>
<!-- Browser menu button that opens AMO in a tab -->
<string name="browser_menu_discover_more_extensions">Discover more extensions</string>
<!-- Browser menu description that is shown when extensions are disabled due to extension errors -->
<string name="browser_menu_extensions_disabled_description">Temporarily disabled</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielluong Please update comment to something like "Browser menu description that is shown when one or more extensions are disabled due to extension errors" (previous comment)
This will help me finalize expsoing the remaining strings in this PR.
Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielluong Ping in case this fell through the cracks

Copy link
Contributor

@Delphine Delphine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more requests for changes.

<!-- Text for the title in the contextual feature recommendation popup promoting the menu feature. -->
<string name="menu_cfr_title">New: streamlined menu</string>
<!-- Text for the message in the contextual feature recommendation popup promoting the menu feature. -->
<string name="menu_cfr_body">Find what you need faster, from private browsing to save actions.</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timc-mozilla: I think this should rather be "(...) to saved actions"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is intended according to the content design in https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?node-id=16563-182996&m=dev

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinged Content Design to be extra sure, thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From EmilyW on Slack: "It's correct because we're referring to actions you use to save, not actions you yourself have saved, or anything about saved in the past tense."

mozilla-mobile/fenix/app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@mozilla-pontoon mozilla-pontoon force-pushed the fenix_l10n_updates branch 9 times, most recently from a89b124 to 2240b87 Compare August 29, 2024 15:12
<!-- Text for the title in the contextual feature recommendation popup promoting the menu feature. -->
<string name="menu_cfr_title">New: streamlined menu</string>
<!-- Text for the message in the contextual feature recommendation popup promoting the menu feature. -->
<string name="menu_cfr_body">Find what you need faster, from private browsing to save actions.</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From EmilyW on Slack: "It's correct because we're referring to actions you use to save, not actions you yourself have saved, or anything about saved in the past tense."

@Delphine Delphine merged commit 7fdee24 into main Aug 29, 2024
2 checks passed
@Delphine Delphine deleted the fenix_l10n_updates branch August 29, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-bot Pull request created by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants