-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import fenix quarantine #793
Conversation
5bf9151
to
2893b2c
Compare
@@ -205,6 +205,8 @@ | |||
<string name="browser_menu_manage_extensions">Manage extensions</string> | |||
<!-- Browser menu button that opens AMO in a tab --> | |||
<string name="browser_menu_discover_more_extensions">Discover more extensions</string> | |||
<!-- Browser menu description that is shown when extensions are disabled due to extension errors --> | |||
<string name="browser_menu_extensions_disabled_description">Temporarily disabled</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabrielluong Please update comment to something like "Browser menu description that is shown when one or more extensions are disabled due to extension errors" (previous comment)
This will help me finalize expsoing the remaining strings in this PR.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabrielluong Ping in case this fell through the cracks
2893b2c
to
8b60a4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more requests for changes.
<!-- Text for the title in the contextual feature recommendation popup promoting the menu feature. --> | ||
<string name="menu_cfr_title">New: streamlined menu</string> | ||
<!-- Text for the message in the contextual feature recommendation popup promoting the menu feature. --> | ||
<string name="menu_cfr_body">Find what you need faster, from private browsing to save actions.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timc-mozilla: I think this should rather be "(...) to saved actions"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is intended according to the content design in https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?node-id=16563-182996&m=dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinged Content Design to be extra sure, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From EmilyW on Slack: "It's correct because we're referring to actions you use to save, not actions you yourself have saved, or anything about saved in the past tense."
a89b124
to
2240b87
Compare
2240b87
to
d8976b6
Compare
<!-- Text for the title in the contextual feature recommendation popup promoting the menu feature. --> | ||
<string name="menu_cfr_title">New: streamlined menu</string> | ||
<!-- Text for the message in the contextual feature recommendation popup promoting the menu feature. --> | ||
<string name="menu_cfr_body">Find what you need faster, from private browsing to save actions.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From EmilyW on Slack: "It's correct because we're referring to actions you use to save, not actions you yourself have saved, or anything about saved in the past tense."
Import fenix quarantine