Posting test cases for NIP47 #520
Conversation
| public void verifySmsThreadNotBlocking() { | ||
| // linking with an API which always returns 202 | ||
| settingsFacade.setProperty(SMS_NOTIFICATION_URL, | ||
| "http://www.mocky.io/v2/55acd492052573e005262f0f"); |
There was a problem hiding this comment.
@AnkitGaurNms @srivastavaAbhi These tests have been commented out from IntegrationTests.java since we don't have an uptime guarantee from mocky.io . While this might be ok to run locally, we have no reliable way to decouple from mocky.io 's service status and our build health.
There was a problem hiding this comment.
@koshalt : That's fine. We look for some other alternative and update cases soon.
|
I'm not sure how this is related to #434 . @frankhuster @srivastavaAbhi ? |
|
What's the status on this? |
|
@koshalt : Idea is to check the code behavior after getting 202 from the IMI. @frankhuster : Any suggestion ? |
| @ResponseStatus(HttpStatus.ACCEPTED) | ||
| @ResponseBody | ||
| public String sendSMS202NIP47(@RequestBody String template) { | ||
| return "OK"; |
There was a problem hiding this comment.
@srivastavaAbhi There seems to be multiple versions of this mock responder api for 200/202 in place in multiple PRs. Can you help consolidate?
There was a problem hiding this comment.
@koshalt Sure. I will do it.
There was a problem hiding this comment.
This PR has been merged into #542
PR for issue #438