Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import and 'Manhatten' typos #26

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions conditional-generation/conditional-generation.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,6 @@
"source": [
"from mostlyai import MostlyAI\n",
"import pandas as pd\n",
"from sklearn.model_selection import train_test_split\n",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see this used anywhere so probably no need for it to be imported.

"\n",
"# fetch original data\n",
"df = pd.read_csv('https://github.com/mostly-ai/public-demo-data/raw/dev/census/census.csv.gz')\n",
Expand Down Expand Up @@ -1621,7 +1620,7 @@
"source": [
"### Explore Synthetic Data\n",
"\n",
"Let's compare the price distribution across Manhatten. Note again, that while the locations in the partially synthetic data are actual locations, all other attributes, incl. the price per night, are randomly sampled by the generative model. Still, these prices are again statistically representative given the context, i.e. the location within Manhattan."
"Let's compare the price distribution across Manhattan. Note again, that while the locations in the partially synthetic data are actual locations, all other attributes, incl. the price per night, are randomly sampled by the generative model. Still, these prices are again statistically representative given the context, i.e. the location within Manhattan."
]
},
{
Expand Down Expand Up @@ -1654,7 +1653,7 @@
],
"source": [
"%%capture --no-display\n",
"def plot_manhatten(df, title):\n",
"def plot_manhattan(df, title):\n",
" ax = df_orig.plot.scatter(\n",
" x='longitude', \n",
" y='latitude', \n",
Expand All @@ -1667,8 +1666,8 @@
" ax.set_title(title)\n",
" plt.show()\n",
" \n",
"plot_manhatten(df_orig, 'Original Data')\n",
"plot_manhatten(syn_partial, 'Partially Synthetic Data')"
"plot_manhattan(df_orig, 'Original Data')\n",
"plot_manhattan(syn_partial, 'Partially Synthetic Data')"
]
},
{
Expand Down